[cppbinding] classParam<T> now keeps ownership of the shared_ptr for … #212
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
…its own lifetime.
Without this change taking a shared_ptr from an API call and passing it to method using classParam causes a nullptr exception, because the shared_ptr would go out of scope to early.
One example is the lib3mf API for the volumetric extension Volumetric.cpp
Instead of having to create objects to keep the shared_ptr alive like
we would now be able to write